This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Conversation
halfalicious
suggested changes
Feb 27, 2019
Contributor
halfalicious
left a comment
There was a problem hiding this comment.
Need to fix test failures and maybe include ethash version
Contributor
|
How did the appveyor configs change? Are these builds still for Windows? |
Member
Author
I restarted AppVeyor build. It usually times out because with first build after Hunter upgrade it has to build and cache dependencies. |
Member
Author
|
Hey @halfalicious, after Windows build restart there are some blockchain tests failures. Can you check maybe on Windows yourself? |
Contributor
Sure, will build overnight and run tests tomorrow. |
Contributor
Getting failures and the stsstoretest appears to have hung (I let the tests run all day and it was still going when I got back) - console output: |
Member
Author
|
Bad news @halfalicious, the stSStoreTest tests run extremely slow. Did you use Debug build? |
Contributor
I did but the test was running for a good few hours, I’d expect it to have completed? I can try running a release build if you’d like. |
Contributor
Re-ran the tests using a release build, still get a failure and a test hang (tests were running for at least 8 hours so I think "BlockhashDoesntNeedLastHashesInExperimental" is hung): |
Upgrades Hunter to v0.23.178. This upgrades following packages: - leveldb to 1.22, it now builds natively on Windows, - Crypto++ to 8.2.0. The ethash stays at version 0.4.4, the current default version in Hunter.
Codecov Report
@@ Coverage Diff @@
## master #5506 +/- ##
=========================================
- Coverage 62.43% 61.9% -0.54%
=========================================
Files 350 345 -5
Lines 29548 28713 -835
Branches 3326 3264 -62
=========================================
- Hits 18448 17774 -674
+ Misses 9898 9773 -125
+ Partials 1202 1166 -36 |
Closed
gumb0
approved these changes
May 29, 2019
gumb0
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Hunter to v0.23.178.
This upgrades following packages:
The ethash stays at version 0.4.4, the current default version in Hunter.