This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Merged
Conversation
gumb0
reviewed
Apr 28, 2017
| // Division equivalence. | ||
|
|
||
| // Built-in type: | ||
| volatile auto d = int64_min; |
Member
There was a problem hiding this comment.
What is this volatile magic for ?
Member
Author
There was a problem hiding this comment.
Nothing important any more. I wanted to check if runtime results are the same as compile-time results so I put volatile to prevent the compiler to compute it up front. I'm not sure it works.
gumb0
approved these changes
Apr 28, 2017
Member
gumb0
left a comment
There was a problem hiding this comment.
Looks fine, except for the not needed volatile and maybe confusing name for utf alias
Member
Author
|
I will change both. The |
8ad37e1 to
f74dbca
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4064 +/- ##
===========================================
+ Coverage 65.74% 65.77% +0.02%
===========================================
Files 308 307 -1
Lines 22778 22831 +53
===========================================
+ Hits 14976 15017 +41
- Misses 7802 7814 +12
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.