Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Aleth uses genesis block as latest block when performing rebuild in response to database minor version mismatch #5822

Closed
#5827
Closed
Aleth uses genesis block as latest block when performing rebuild in response to database minor version mismatch#5822
#5827
Labels
bugdatabaseDatabase-related work
@halfalicious

Description

@halfalicious
halfalicious
opened on Nov 14, 2019

Even if we address #5813 and persist the minor version to disk, BlockChain::open() renames the extras database path on minor version mismatch:

aleth/libethereum/BlockChain.cpp

Lines 213 to 222 in cd25d2f

if (c_minorProtocolVersion != lastMinor)
{
cnote << "Killing extras database " << extrasPath << " (DB minor version:" << lastMinor
<< " != our minor version: " << c_minorProtocolVersion << ").";
DEV_IGNORE_EXCEPTIONS(fs::remove_all(extrasPath / fs::path("details.old")));
fs::rename(extrasSubPathExtras, extrasPath / fs::path("extras.old"));
fs::remove_all(extrasPath / fs::path("state"));
writeFile(extrasSubPathMinor, rlp(c_minorProtocolVersion));
lastMinor = (unsigned)RLP(status);
}

It then opens the extras DB from the old path and populates m_lastBlockHash / m_lastBlockNumber to the genesis block since the old path is empty.

Therefore the last block hash used by BlockChain::rebuild() to identify the range of blocks which need to be reimported will be the genesis block, and the extras (and state) databases won't actually be rebuilt.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdatabaseDatabase-related work

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions