Update EIP-6110: harmonize request eips with 7685 changes#8949
Merged
lightclient merged 2 commits intoethereum:masterfrom Oct 10, 2024
Merged
Update EIP-6110: harmonize request eips with 7685 changes#8949lightclient merged 2 commits intoethereum:masterfrom
lightclient merged 2 commits intoethereum:masterfrom
Conversation
Collaborator
File
|
ensi321
reviewed
Oct 10, 2024
| @@ -73,11 +73,9 @@ Note that `amount` is returned by the contract little-endian, and must be encode | |||
|
|
|||
Contributor
There was a problem hiding this comment.
The EIP-7685 encoding of a withdrawal request is computed as follows.
Can you also fix the above link to [EIP-7685](./eip-7685.md)? It is missing the md extension
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up 6110, 7002, and 7251 with respect to the modifications to 7685. Specifically,
request_datanow refers to the output of the system call to the contracts, not an individual request object's data.