Skip to content

Update EIP-1: Permit links to Execution Specs#6306

Merged
eth-bot merged 4 commits intoethereum:masterfrom
pcaversaccio:update-refs
Apr 6, 2023
Merged

Update EIP-1: Permit links to Execution Specs#6306
eth-bot merged 4 commits intoethereum:masterfrom
pcaversaccio:update-refs

Conversation

@pcaversaccio
Copy link
Copy Markdown
Contributor

This PR adds the Ethereum Execution Client Specifications as well as the Ethereum Yellow Paper as permitted links to EIP-1. The related draft EIP triggering this PR is #6269.

@pcaversaccio pcaversaccio requested a review from eth-bot as a code owner January 10, 2023 16:19
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Jan 10, 2023
@eth-bot
Copy link
Copy Markdown
Collaborator

eth-bot commented Jan 10, 2023

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 10, 2023
@SamWilsn SamWilsn mentioned this pull request Jan 10, 2023
7 tasks
@Pandapip1 Pandapip1 changed the title EIP-1: Update permitted links Update EIP-1: Update permitted links Jan 10, 2023
pcaversaccio and others added 2 commits January 10, 2023 18:50
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Pandapip1
Pandapip1 previously approved these changes Jan 10, 2023
Copy link
Copy Markdown
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

(shouldn't automerge, if it does, it should be rolled back)

@lightclient
Copy link
Copy Markdown
Member

I am +1 on execution spec and -1 on yellow paper.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

pcaversaccio commented Jan 11, 2023

I am +1 on execution spec and -1 on yellow paper.

I need the Yellow Paper as a reference in order to make #6269 backwards-compatible. There were no execution specs in 2014 onwards...

@SamWilsn
Copy link
Copy Markdown
Contributor

There are going to be some changes to the EIP process that will affect how it interacts with the execution-specs. Unfortunately we don't know exactly what those changes are going to be, and it might not make a ton of sense to allow links to the execution-specs (eg. if we have a whole new process for execution-spec changes.) I'm hesitant to allow links to EELS until the dust settles on that.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

pcaversaccio commented Jan 25, 2023

There are going to be some changes to the EIP process that will affect how it interacts with the execution-specs.

Sorry I'm confused - 2 weeks ago you ask me here to open a PR to EIP-1 to add the proposed links. Now it seems the world has completely changed since then. I would appreciate some transparency about what is happening on the EIP process side since it significantly impacts my own EIP proposal #6269. I know you state that you don't know what changes will happen, but could you explain quickly at least what process you're running? That would be much appreciated.

@SamWilsn
Copy link
Copy Markdown
Contributor

Sorry I'm confused - 2 weeks ago you ask me here to open a PR to EIP-1 to add the proposed links.

Yeah, sorry about the confusion. It's easier to talk about governance issues when we have a concrete pull request to discuss.


After discussing on today's EIPIP meeting, I think we're generally positive on adding this. I'll bug @lightclient in case he absolutely doesn't want to allow Yellow Paper links.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

Thanks for the heads-up - a quick question for discussion here. As you might know, I also plan to draft an EIP on Full Ethereum Equivalence and for that, I would have to partially use the Ethereum Consensus Tests. Now I wanted to ask whether there is a clear objection from your side to adding this as well. As background, many zkEVMs and optimistic Rollups use this metric to showcase compatibility or even equivalence.

@Pandapip1
Copy link
Copy Markdown
Member

Now I wanted to ask whether there is a clear objection from your side to adding this as well.

Please add that in a separate PR. Adding it to this PR will make it harder to reach a consensus (or a compromise, if need be).

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

pcaversaccio commented Jan 25, 2023

Please add that in a separate PR. Adding it to this PR will make it harder to reach a consensus (or a compromise, if need be).

Sure, will do it once I drafted the EIP where this is needed.

@Pandapip1 Pandapip1 changed the title Update EIP-1: Update permitted links Update EIP-1: Update permitted links to include Yellow Paper and Execution Specs Jan 25, 2023
@Pandapip1 Pandapip1 changed the title Update EIP-1: Update permitted links to include Yellow Paper and Execution Specs Update EIP-1: Permitted links to Yellow Paper and Execution Specs Jan 25, 2023
@Pandapip1 Pandapip1 changed the title Update EIP-1: Permitted links to Yellow Paper and Execution Specs Update EIP-1: Permit links to Yellow Paper and Execution Specs Jan 25, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 25, 2023
@github-actions
Copy link
Copy Markdown

The commit 33c436e (as a parent of 75ffa88) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 25, 2023
@SamWilsn
Copy link
Copy Markdown
Contributor

I suppose I have no strong objection to linking to the tests repository.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

@SamWilsn but would like to have it as part of this PR already? As pointed out by @Pandapip1, I don't want to make it harder to find a consensus for this PR :)

@Pandapip1
Copy link
Copy Markdown
Member

@pcaversaccio I'm a bit concerned that the more links that are allowed in a single PR, the harder it will be to get any of them merged. Already, the Yellow Paper is the only thing that's blocking this PR.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

@Pandapip1 agreed - so I will refrain from submitting another link.

@Pandapip1
Copy link
Copy Markdown
Member

In the meantime, feel free to submit more PRs!

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

I will submit the PR with the additional links once I drafted the EIP for Full Ethereum Equivalence. However, before doing this we need first to find an agreement in #6269.

@wschwab
Copy link
Copy Markdown
Contributor

wschwab commented Feb 19, 2023

I honestly think linking to the Yellow Paper should also be allowed, fwiw. Even if the Execution Specs are the canonical way moving forward, the Yellow Paper was the original specification, and was still at the least a definitive part of defining Ethereum until the migration to the Specs began (all of the problems with it notwithstanding).

imho it's easy to envision EIPs that make reference to the Yellow Paper to validate assertions or define what expected behavior is within the context of an EIP. As such, the logical course would be to allow links to the Paper, again imho.

@pcaversaccio
Copy link
Copy Markdown
Contributor Author

@lightclient @SamWilsn @Pandapip1 - any update on how we progress from here now?

@Pandapip1
Copy link
Copy Markdown
Member

We're just waiting on more editors to approve or voice their objections.

@xinbenlv
Copy link
Copy Markdown
Contributor

xinbenlv commented Apr 5, 2023

I am in strong favor of allowing both Yellow Paper and Execution Spec. If no full consensus, I am ok to merge a PR to add Exec-Specs first and wait for consensus to merge another PR to add Yellow Paper.

@lightclient
Copy link
Copy Markdown
Member

I absolutely do not think the yellow paper should be an acceptable resource in the EIPs repository.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 5, 2023
@SamWilsn SamWilsn changed the title Update EIP-1: Permit links to Yellow Paper and Execution Specs Update EIP-1: Permit links to Execution Specs Apr 5, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 5, 2023
@SamWilsn SamWilsn closed this Apr 5, 2023
@SamWilsn SamWilsn reopened this Apr 5, 2023
@eth-bot eth-bot enabled auto-merge (squash) April 6, 2023 19:22
Copy link
Copy Markdown
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 7a6ebcc into ethereum:master Apr 6, 2023
@pcaversaccio pcaversaccio deleted the update-refs branch April 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants