Update EIP-1: add devp2p repo as accepted external resource#6034
Merged
SamWilsn merged 2 commits intoethereum:masterfrom Nov 28, 2022
Merged
Update EIP-1: add devp2p repo as accepted external resource#6034SamWilsn merged 2 commits intoethereum:masterfrom
SamWilsn merged 2 commits intoethereum:masterfrom
Conversation
MariusVanDerWijden
previously approved these changes
Nov 23, 2022
Collaborator
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-1.md
|
Pandapip1
reviewed
Nov 23, 2022
|
|
||
| ### Networking Specifications | ||
|
|
||
| Links to the Ethereum Networking Specifications may be included using normal markdown syntax, such as: |
Member
There was a problem hiding this comment.
Suggested change
| Links to the Ethereum Networking Specifications may be included using normal markdown syntax, such as: | |
| Links to specific commits and files in specific commits of the Ethereum Networking Specifications GitHub repository may be included using the normal markdown link syntax, such as: |
Contributor
There was a problem hiding this comment.
The text should be consistent between consensus and networking specs.
Member
There was a problem hiding this comment.
Can I suggest that the text be changed for both, then?
Pandapip1
reviewed
Nov 23, 2022
Contributor
|
I'll make @Pandapip1's changes in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add the Ethereum networking specs (devp2p) as an accepted resource to EIP-1.