Update EIP-7928: Disallow empty change set for storage slot#11750
Merged
Conversation
Collaborator
|
✅ All reviewers have approved. |
eth-bot
approved these changes
Jun 1, 2026
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Contributor
|
Are there tests for it? I assume it's covered in existing tests already. |
4 tasks
Member
Author
|
Added a new one which injects empty slot and check if clients reject it. ethereum/execution-specs#2945 Could you add this to your BAL agenda for ACDT? |
4 tasks
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow storage slot with empty changes:
This is meaningless and can be potentially ambiguous.