-
-
Notifications
You must be signed in to change notification settings - Fork 3k
regression on 'getHTML' backend test #3425
Copy link
Copy link
Closed
Labels
Milestone
Description
PR #3268 caused a regression on the 'getHTML' backend test.
Expected:
<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</li></ul><br><ul><ul class="bullet"><li>ul2</li></ul></ul></body></html>Received:
<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</ul><br><ul class="bullet"><li><ul class="bullet"><li>ul2</ul></li></ul></body></html>The regression bisects to PR 3268, that changes src/node/utils/ExportHtml.js.
Steps to reproduce:
- clean up the installation:
rm -rf node_modules src/node_modules - update to revision bacc37c (the last one before merging the PR)
- start Etherpad with
bin/run.sh - in another console, start
bin/backendTests.sh(the whole test suite takes ~2 seconds to run) - the tests will pass
- stop Etherpad
- update to revision fe08d2a (the one that merged the PR)
- start Etherpad with
bin/run.sh - in another console, start
bin/backendTests.sh - the test will not pass
- if you also want to see the wrong output given above, perform the same test on revision f2b5f3b, which introduces an explicit error message
@ilmartyrk could you have a look?
Reactions are currently unavailable