Skip to content

regression on 'getHTML' backend test #3425

@muxator

Description

@muxator

PR #3268 caused a regression on the 'getHTML' backend test.

Expected:

<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</li></ul><br><ul><ul class="bullet"><li>ul2</li></ul></ul></body></html>

Received:

<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</ul><br><ul class="bullet"><li><ul class="bullet"><li>ul2</ul></li></ul></body></html>

The regression bisects to PR 3268, that changes src/node/utils/ExportHtml.js.

Steps to reproduce:

  1. clean up the installation: rm -rf node_modules src/node_modules
  2. update to revision bacc37c (the last one before merging the PR)
  3. start Etherpad with bin/run.sh
  4. in another console, start bin/backendTests.sh (the whole test suite takes ~2 seconds to run)
  5. the tests will pass
  6. stop Etherpad
  7. update to revision fe08d2a (the one that merged the PR)
  8. start Etherpad with bin/run.sh
  9. in another console, start bin/backendTests.sh
  10. the test will not pass
  11. if you also want to see the wrong output given above, perform the same test on revision f2b5f3b, which introduces an explicit error message

@ilmartyrk could you have a look?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions