-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
async-migrationMigration from callback-style programming to async functionsMigration from callback-style programming to async functionspackagingsecuritystale code
Milestone
Description
A recent issue (#3401) suggests that when using Node <= 4 the application works (edit: as of 1.6.6, it no longer does), but plugins do not get installed. Upgrading to Node 6 solved that specific issue.
Maybe we should decide what is the minumim required Node version, and be clear about that.
installDeps.sh checks for Node >= 0.10:
etherpad-lite/bin/installDeps.sh
Line 51 in 7c971f2
| if [ ! $NODE_V_MINOR = "v0.10" ] && [ ! $NODE_V_MINOR = "v0.11" ] && [ ! $NODE_V_MINOR = "v0.12" ] && [ ! $NODE_V_MAIN -ge 4 ]; then |
but probably we should reconsider: Node 6 is currently the oldest supported version (going out of support on April 2019).
Using a more recent Node version could probably give us the possibility of modernizing the codebase, too (for example: async/await vs callbacks).
Metadata
Metadata
Assignees
Labels
async-migrationMigration from callback-style programming to async functionsMigration from callback-style programming to async functionspackagingsecuritystale code