Skip to content

*: Fix embedded mutexes leaking methods#7833

Closed
s111 wants to merge 1 commit intoetcd-io:masterfrom
s111:fixmutexleak
Closed

*: Fix embedded mutexes leaking methods#7833
s111 wants to merge 1 commit intoetcd-io:masterfrom
s111:fixmutexleak

Conversation

@s111
Copy link
Copy Markdown

@s111 s111 commented Apr 27, 2017

This pull request cleans up all exported structs that were leaking the Lock/Unlock methods from an embedded mutex.

@xiang90 xiang90 requested review from jonboulle and removed request for jonboulle April 27, 2017 22:28
@heyitsanthony
Copy link
Copy Markdown

heyitsanthony commented Apr 27, 2017

@s111 is there a linter/tool for detecting this?

@s111
Copy link
Copy Markdown
Author

s111 commented Apr 27, 2017 •
edited
Loading

@heyitsanthony I've written a quick extension of golint for my own use: https://github.com/s111/lint.

@heyitsanthony
Copy link
Copy Markdown

heyitsanthony commented Apr 27, 2017

@s111 any way that patch can get into golint upstream or some other linter? If it's a style problem worth fixing I'd like to be able to catch it as part of CI...

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 28, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4301f49). Click here to learn what that means.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7833   +/-   ##
=========================================
  Coverage          ?   75.91%           
=========================================
  Files             ?      332           
  Lines             ?    26177           
  Branches          ?        0           
=========================================
  Hits              ?    19871           
  Misses            ?     4887           
  Partials          ?     1419
Impacted Files Coverage Δ
raft/storage.go 87.96% <100%> (ø)
pkg/testutil/recorder.go 70.37% <100%> (ø)
etcdserver/stats/leader.go 79.48% <75%> (ø)
etcdserver/stats/server.go 71.66% <75%> (ø)
etcdserver/membership/cluster.go 86.98% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4301f49...38d0ebe. Read the comment docs.

@gyuho
Copy link
Copy Markdown
Contributor

gyuho commented May 2, 2017

@sebschrader If your patch s111/lint@d196a16 goes in upstream, it would be great.

lgtm. Thanks!

@sebschrader
Copy link
Copy Markdown
Contributor

sebschrader commented May 8, 2017

Hey @gyuho, you seem to have erroneously mentioned me here.

@gyuho
Copy link
Copy Markdown
Contributor

gyuho commented May 9, 2017

@sebschrader Apology! I meant to mention @s111

Thanks!

@gyuho gyuho force-pushed the master branch 2 times, most recently from 44ca396 to 4301f49 Compare June 2, 2017 15:53
@gyuho gyuho mentioned this pull request Jun 8, 2017
Closed
@stale
Copy link
Copy Markdown

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@s111 @heyitsanthony @codecov-io @gyuho @sebschrader