[3.5] Print warning message for deprecated v2 flags if set#18999
Merged
ahrtr merged 1 commit intoetcd-io:release-3.5from Dec 4, 2024
Merged
[3.5] Print warning message for deprecated v2 flags if set#18999ahrtr merged 1 commit intoetcd-io:release-3.5from
ahrtr merged 1 commit intoetcd-io:release-3.5from
Conversation
fuweid
reviewed
Dec 3, 2024
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
a03be2c to
28a19f7
Compare
jmhbnz
approved these changes
Dec 3, 2024
ivanvc
approved these changes
Dec 3, 2024
serathius
approved these changes
Dec 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
serathius
reviewed
Dec 4, 2024
| Number of samples to collect per million spans for distributed tracing. Disabled by default. | ||
|
|
||
| v2 Proxy (to be deprecated in v3.6): | ||
| v2 Proxy (Deprecated and to be decommissioned in v3.6): |
Member
Author
There was a problem hiding this comment.
The flags have already been decommissioned/removed in 3.6/main branch.
Member
There was a problem hiding this comment.
Ok, so this PR is about making the warning more visible and standardized between branches. Thanks!
This was referenced Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12913
cc @fuweid @serathius @ivanvc @jmhbnz