Add a threshold for codecov failure#18964
Conversation
Signed-off-by: James Blair <mail@jamesblair.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18964 +/- ##
==========================================
+ Coverage 68.67% 68.74% +0.07%
==========================================
Files 420 420
Lines 35583 35583
==========================================
+ Hits 24438 24463 +25
+ Misses 9713 9690 -23
+ Partials 1432 1430 -2 Continue to review full report in Codecov by Sentry.
|
serathius
left a comment
There was a problem hiding this comment.
1% of whole codebase might make it never trigger. On the other hand I don't think kind of check could be ever automated. Would rather depend on approvers to see that there is a new feature with low covereage.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now that we have enabled proper codecov integration in kubernetes/org#5231 we have noticed pr's being failed for coverage reductions that are trivial, i.e. < .1%.
Let's try and introduce some configuration to make codecov only fail when a meaningful reduction in coverage has occurred.
cc @serathius