Skip to content

[3.4] Backport clientv3 naming implementation#16800

Merged
ahrtr merged 3 commits intoetcd-io:release-3.4from
chaochn47:release-3.4-clientv3-naming-impl
Oct 25, 2023
Merged

[3.4] Backport clientv3 naming implementation#16800
ahrtr merged 3 commits intoetcd-io:release-3.4from
chaochn47:release-3.4-clientv3-naming-impl

Conversation

@chaochn47
Copy link
Copy Markdown
Member

@chaochn47 chaochn47 commented Oct 20, 2023

Part of #16740

Backport #12614, #12667, #12669 and #12675 to release-3.4

Corresponding tests should have been enabled.

Please DO NOT MERGE until this PR is rebased on top of #16795

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@chaochn47 chaochn47 requested a review from fuweid October 20, 2023 04:37
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from d8be61d to 65e6915 Compare October 20, 2023 04:53
@chaochn47 chaochn47 changed the title Release 3.4 clientv3 naming impl [3.4] Backport clientv3 naming implementation Oct 20, 2023
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from 65e6915 to 23f6937 Compare October 20, 2023 05:08
@ahrtr ahrtr mentioned this pull request Oct 20, 2023
Closed
24 tasks
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Oct 24, 2023

#16795 has been merged, please rebase this PR, thx

@chaochn47
[3.4] backport 12667: Implement Update method for EndpointManager
15d6a11 
Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from 23f6937 to d2cc99a Compare October 24, 2023 15:10
@chaochn47 chaochn47 marked this pull request as ready for review October 24, 2023 15:10
@chaochn47
Copy link
Copy Markdown
Member Author

chaochn47 commented Oct 24, 2023

Thanks @ahrtr! I have rebased the PR. PTAL~

@ahrtr ahrtr mentioned this pull request Oct 24, 2023
Merged
@chaochn47
[3.4] backport 12669: Implement Endpoint Watch and new Resolver
7c4696a 
Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from d2cc99a to fa2e868 Compare October 24, 2023 15:59
@chaochn47
Copy link
Copy Markdown
Member Author

chaochn47 commented Oct 24, 2023 •
edited
Loading

Known flaky test should be fixed by #15708 as long as it is backported. Retrying...

=== RUN   TestMemberPromoteMemberNotLearner
{"level":"warn","ts":"2023-10-24T16:05:20.153924Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = FailedPrecondition desc = etcdserver: can only promote a learner member"}
{"level":"warn","ts":"2023-10-24T16:05:20.159936Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = FailedPrecondition desc = etcdserver: can only promote a learner member"}
{"level":"warn","ts":"2023-10-24T16:05:25.361631Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-506ab2c9-cfe6-49c3-ad6a-a51f4cd85750/localhost:56549785845390747520","attempt":0,"error":"rpc error: code = Unavailable desc = etcdserver: request timed out"}
    cluster_test.go:326: expect error to contain can only promote a learner member, got etcdserver: request timed out
--- FAIL: TestMemberPromoteMemberNotLearner (5.35s)

https://github.com/etcd-io/etcd/actions/runs/6629437579/job/18008727923?pr=16800

@chaochn47
[3.4] backport 12675: Cleanup grpc clientv3/naming API
e61f1d8 
Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 force-pushed the release-3.4-clientv3-naming-impl branch from fa2e868 to e61f1d8 Compare October 24, 2023 16:17
ahrtr
ahrtr approved these changes Oct 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Oct 24, 2023

cc @fuweid @jmhbnz @serathius @wenjiaswe

@chaochn47 chaochn47 mentioned this pull request Oct 25, 2023
Merged
@ahrtr ahrtr merged commit e031012 into etcd-io:release-3.4 Oct 25, 2023
@chaochn47 chaochn47 deleted the release-3.4-clientv3-naming-impl branch October 25, 2023 19:54
@ahrtr ahrtr mentioned this pull request Apr 28, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

@fuweid fuweid Awaiting requested review from fuweid

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaochn47 @ahrtr @serathius