[3.4] Backport #16272 to 3.4#16309
Merged
ahrtr merged 1 commit intoetcd-io:release-3.4from Jul 27, 2023
callthingsoff:release-3.4
Merged
[3.4] Backport #16272 to 3.4#16309ahrtr merged 1 commit intoetcd-io:release-3.4from callthingsoff:release-3.4
ahrtr merged 1 commit intoetcd-io:release-3.4from
callthingsoff:release-3.4
Conversation
From the name of func 'UniqueURLsFromFlag', we can tell that UniqueURLs'uss should not have duplicates. The current implemention of UniqueURLs'Set has a bug to make it unique. This PR fixes it. Signed-off-by: Jes Cok <xigua67damn@gmail.com>
ahrtr
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #16272
Fix UniqueURLs'Set to remove duplicates in UniqueURLs'uss.
Fixes: #16307
TODO: changelog for 3.4 after this pr is merged.