Skip to content

Fix flaky integration/clientv3/naming TestEtcdGrpcResolverRoundRobin#16263

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
Rajalakshmi-Girish:flake-grpc-rr
Jul 18, 2023
Merged

Fix flaky integration/clientv3/naming TestEtcdGrpcResolverRoundRobin#16263
ahrtr merged 1 commit intoetcd-io:mainfrom
Rajalakshmi-Girish:flake-grpc-rr

Conversation

@Rajalakshmi-Girish
Copy link
Copy Markdown
Contributor

@Rajalakshmi-Girish Rajalakshmi-Girish commented Jul 18, 2023

jmhbnz
jmhbnz approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jmhbnz jmhbnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the quick pr @Rajalakshmi-Girish.

@jmhbnz
Copy link
Copy Markdown
Member

jmhbnz commented Jul 18, 2023

@Rajalakshmi-Girish Can you also please update this line, to keep the other test case in sync for pickfirst policy https://github.com/etcd-io/etcd/pull/16263/files#diff-c071d29295c1957edb2f89b5156c255dacce02ddff2cf962f6b347f4fce0042dR114

@Rajalakshmi-Girish
Fix flaky integration/clientv3/naming TestEtcdGrpcResolverRoundRobin
ea72194 
Signed-off-by: Rajalakshmi Girish <rajalakshmi.girish1@ibm.com>
@ahrtr ahrtr merged commit e209968 into etcd-io:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

integration/clientv3/naming TestEtcdGrpcResolverRoundRobin is flaking

4 participants

@Rajalakshmi-Girish @jmhbnz @serathius @ahrtr