Skip to content

Add changelog for backport 13577 to 3.4&3.5.#16251

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
liangyuanpeng:changelog_backport_13577
Jul 17, 2023
Merged

Add changelog for backport 13577 to 3.4&3.5.#16251
ahrtr merged 1 commit intoetcd-io:mainfrom
liangyuanpeng:changelog_backport_13577

Conversation

@liangyuanpeng
Copy link
Copy Markdown
Contributor

@liangyuanpeng liangyuanpeng force-pushed the changelog_backport_13577 branch 2 times, most recently from 42337fd to 7c80a61 Compare July 16, 2023 04:16
Copy link
Copy Markdown
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @liangyuanpeng

Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @liangyuanpeng

Comment thread CHANGELOG/CHANGELOG-3.4.md Outdated
- Improve [Skip getting authInfo from incoming context when auth is disabled](https://github.com/etcd-io/etcd/pull/16240)

### Package `clientv3`
- Improve [Reset auth token when failing to authenticate due to auth being disabled](https://github.com/etcd-io/etcd/pull/16240)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a bug fix. Previously when disabling auth, the client still always carries a invalid token.

Suggested change
- Improve [Reset auth token when failing to authenticate due to auth being disabled](https://github.com/etcd-io/etcd/pull/16240)
- Fix [Reset auth token when failing to authenticate due to auth being disabled](https://github.com/etcd-io/etcd/pull/16240)

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng liangyuanpeng force-pushed the changelog_backport_13577 branch from 7c80a61 to 6a9ea5b Compare July 17, 2023 05:39
@ahrtr ahrtr merged commit bedd132 into etcd-io:main Jul 17, 2023
@liangyuanpeng liangyuanpeng deleted the changelog_backport_13577 branch July 17, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Backport https://github.com/etcd-io/etcd/pull/13577 to both 3.5 and 3.4

3 participants