clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…#16200
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Jul 14, 2023
Merged
clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…#16200ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr merged 1 commit intoetcd-io:mainfrom
Conversation
…eled Signed-off-by: zhangwenkang <zwenkang@vmware.com>
fuweid
reviewed
Jul 10, 2023
This was referenced Jul 10, 2023
Contributor
Author
ok |
jmhbnz
approved these changes
Jul 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We always create a
keepAliveCtxClosergoroutine to eagerly updatekeepAlivewhen ctx is done.But if ctx can never be canceled, there is no need to start a redundant goroutine.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.