tools/benchmark: support limit flag for range#15948
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom May 25, 2023
Merged
Conversation
ahrtr
reviewed
May 25, 2023
| rangeCmd.Flags().IntVar(&rangeRate, "rate", 0, "Maximum range requests per second (0 is no limit)") | ||
| rangeCmd.Flags().IntVar(&rangeTotal, "total", 10000, "Total number of range requests") | ||
| rangeCmd.Flags().StringVar(&rangeConsistency, "consistency", "l", "Linearizable(l) or Serializable(s)") | ||
| rangeCmd.Flags().Int64Var(&rangeLimit, "limit", 0, "Maximum result number for range request (0 is no limit)") |
Member
There was a problem hiding this comment.
minor comment:
Suggested change
| rangeCmd.Flags().Int64Var(&rangeLimit, "limit", 0, "Maximum result number for range request (0 is no limit)") | |
| rangeCmd.Flags().Int64Var(&rangeLimit, "limit", 0, "Maximum number of results to return from range request (0 is no limit)") |
With limit flag, we can verify the performance for the pagination. Signed-off-by: Wei Fu <fuweid89@gmail.com>
b4e13bd to
b365f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With limit flag, we can verify the performance for the pagination.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.