Add the rotation worksheet into the dependency management document#15946
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Jun 2, 2023
Merged
Add the rotation worksheet into the dependency management document#15946ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr merged 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: Benjamin Wang <wachao@vmware.com>
fuweid
reviewed
May 24, 2023
Member
fuweid
left a comment
There was a problem hiding this comment.
LGTM
Maybe we should add the final state is that the dep can be handled by bot, something like that.
chaochn47
approved these changes
May 24, 2023
jmhbnz
approved these changes
May 24, 2023
Member
jmhbnz
left a comment
There was a problem hiding this comment.
LGTM - So far the roster is working ok I think. In future if we have any gaps we can always do a quick message on etcd slack or make a good-first-issue to get some more people involved.
pchan
reviewed
May 25, 2023
Member
Author
|
ping @mitake @ptabor @serathius @spzala |
serathius
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Please feel free to suggest a better way to track this. I am OK as long as majority are happy.
cc @mitake @ptabor @serathius @jmhbnz @chaochn47 @fuweid @lavacat @pchan @ArkaSaha30 @sharathsivakumar