Documentation: describe onboarding process#15911
Conversation
|
I'd like to have comments on below points:
|
|
|
||
| ### Onboarding process | ||
|
|
||
| - Open a PR and add an entry to the [MAINTAINERS] file. |
There was a problem hiding this comment.
As maintainer requires a supermajority I would make an exception that this should be done privatly.
I would start from asking two maintainers to become a sponsor and sending an email with candidacy to [etcd-maintainers-private@googlegroups.com] asking for a vote.
Existing maintainers would then vote privatly (move discussion to bbc) allowing a full transparency. After votes are cast one of maintainers would respond with result to the original email. Either positive or negative with feedback for suggested improvement.
If result is positive, candidate can file a public PR
There was a problem hiding this comment.
+1 Basically makes sense to me.
If result is positive, candidate can file a public PR
Any of the existing maintainers can also raise a public PR after there is a agreement;
There was a problem hiding this comment.
Any of the existing maintainers can also raise a public PR after there is a agreement;
Sure, however I would like to follow K8s and have the process driven by candidate so it doesn't get stuck on maintainer and the candidate doesn't need to wait for creating the PR.
There was a problem hiding this comment.
I think the steps are good, will describe in the file. But IIUC only maintainers can send emails to [etcd-maintainers-private@googlegroups.com], so a candidate should use [etcd-maintainers@googlegroups.com]?
There was a problem hiding this comment.
I think everyone can send emails to etcd-maintainers-private@googlegroups.com, but only maintainers can read them.
There was a problem hiding this comment.
I checked the config and that’s true, let me update the description.
spzala
left a comment
There was a problem hiding this comment.
Thanks @mitake !! I agree with comments from @serathius
Also, I think some duplication, of couple of sentences, among different sections is usually fine as it helps thoroughly review a specific section.
|
|
||
| ### Onboarding process | ||
|
|
||
| - Open a PR and add an entry to the [MAINTAINERS] file. |
ebf5367 to
21ed891
Compare
|
I think you picked up my old commit. Please remove it, if you need help with that let me know. |
|
@serathius sorry I rebased on the latest main and removed the commit from this branch. |
123bd4c to
0e1e96c
Compare
|
@mitake Please mark this PR as Ready for review once it's ready. Overall looks good to me! |
|
Also looks good to me, I think it would be reasonable to mention the secrets even if we don't want immediately migrate them to shared storage. We could leave a TODO :P |
|
@ahrtr @serathius thanks for checking, I marked this PR as ready to be reviewed. I added a description like this to GCP project line: |
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com> Co-authored-by: Marek Siarkowicz <siarkowicz@google.com>
|
Awesome work! Thanks for helping new maintainers onboard! |
|
@serathius Thanks for improving the descriptions! Let me merge. |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @serathius @ahrtr @spzala @ptabor
I think it's good to update onboarding process for members and reviewers too.