Skip to content

etcdserver: wait for raft being notified on confChange before responding to client#15703

Closed
ahrtr wants to merge 1 commit intoetcd-io:mainfrom
ahrtr:confchange_raft_sync_20230412
Closed

etcdserver: wait for raft being notified on confChange before responding to client#15703
ahrtr wants to merge 1 commit intoetcd-io:mainfrom
ahrtr:confchange_raft_sync_20230412

Conversation

@ahrtr
Copy link
Copy Markdown
Member

@ahrtr ahrtr commented Apr 12, 2023

@ahrtr ahrtr marked this pull request as draft April 12, 2023 10:55
@ahrtr ahrtr changed the title etcdserver: wait for raft is notified on confChange before responding to client etcdserver: wait for raft being notified on confChange before responding to client Apr 12, 2023
@ahrtr ahrtr force-pushed the confchange_raft_sync_20230412 branch from 9c0263e to e52d87e Compare April 12, 2023 11:03
@ahrtr ahrtr mentioned this pull request Apr 12, 2023
Closed
@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Apr 12, 2023

#15528 (comment)

@ahrtr ahrtr mentioned this pull request Apr 12, 2023
Closed
@chaochn47
Copy link
Copy Markdown
Member

chaochn47 commented Apr 13, 2023

Please anyone feel free to continue to work on top of my PR

The approach looks good to me.

@ahrtr, how does "work on top of my PR" work? Is it cherry-pick your commit somehow and add my changes (rename and add tests) on top of it?

@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Apr 13, 2023

@ahrtr, how does "work on top of my PR" work? Is it cherry-pick your commit somehow and add my changes (rename and add tests) on top of it?

Sounds good to me. Or

  1. fork a dev-branch on top of my dev-branch (confchange_raft_sync_20230412 in this case);
  2. rebase the branch;
  3. add your new commits on top of it.

@chaochn47
Copy link
Copy Markdown
Member

chaochn47 commented Apr 13, 2023

@ahrtr, how does "work on top of my PR" work? Is it cherry-pick your commit somehow and add my changes (rename and add tests) on top of it?

Sounds good to me. Or

1. fork a dev-branch on top of my dev-branch (`confchange_raft_sync_20230412` in this case);

2. rebase the branch;

3. add your new commits on top of it.

That is easier! Thanks!!

@chaochn47 chaochn47 mentioned this pull request Apr 13, 2023
Merged
@serathius serathius closed this Apr 13, 2023
@serathius
Copy link
Copy Markdown
Member

serathius commented Apr 13, 2023

Closing to avoid confusion as work will continue in #15708.

@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Jun 28, 2023

Reopen for test/verification only

@ahrtr ahrtr reopened this Jun 28, 2023
@ahrtr
etcdserver: wait for raft is notified on confChange before responding…
cf1b668 
… to client

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr force-pushed the confchange_raft_sync_20230412 branch from e52d87e to cf1b668 Compare June 28, 2023 08:37
@ahrtr ahrtr closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahrtr @chaochn47 @serathius