Skip to content

tests: increase maxWatchDelay to prevent flaky TestWatchDelay*#15636

Merged
serathius merged 1 commit intoetcd-io:mainfrom
lavacat:main-test-watch-delay
Apr 4, 2023
Merged

tests: increase maxWatchDelay to prevent flaky TestWatchDelay*#15636
serathius merged 1 commit intoetcd-io:mainfrom
lavacat:main-test-watch-delay

Conversation

@lavacat
Copy link
Copy Markdown

@lavacat lavacat commented Apr 4, 2023

value is selected empirically after spot checking some logs of flaky workflows

fixes: #15634

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

tests: increase maxWatchDelay to prevent flaky TestWatchDelay*
7579109 
value is selected empirically after spot checking some logs of flaky workflows

fixes: etcd-io#15634
Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
@lavacat lavacat requested a review from serathius April 4, 2023 04:51
@lavacat
Copy link
Copy Markdown
Author

lavacat commented Apr 4, 2023 •
edited
Loading

failed e2e run is due to unrelated test TestV3CurlCipherSuitesMismatch

2023-04-04T05:04:28.2104817Z --- FAIL: TestV3CurlCipherSuitesMismatch (1.05s)
2023-04-04T05:04:28.2105267Z before.go:36: Changing working directory to: /tmp/TestV3CurlCipherSuitesMismatch1594496831/001
2023-04-04T05:04:28.2105861Z logger.go:130: 2023-04-04T05:01:49.611Z INFO starting server... {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2112917Z logger.go:130: 2023-04-04T05:01:49.611Z INFO spawning process {"args": ["/home/runner/work/etcd/etcd/bin/etcd", "--name", "TestV3CurlCipherSuitesMismatch-test-0", "--listen-client-urls", "https://localhost:20000", "--advertise-client-urls", "https://localhost:20000", "--listen-peer-urls", "http://localhost:20001", "--initial-advertise-peer-urls", "http://localhost:20001", "--initial-cluster-token", "new", "--data-dir", "/tmp/TestV3CurlCipherSuitesMismatch1594496831/002", "--snapshot-count", "10000", "--experimental-initial-corrupt-check", "--cert-file", "/home/runner/work/etcd/etcd/tests/fixtures/server.crt", "--key-file", "/home/runner/work/etcd/etcd/tests/fixtures/server.key.insecure", "--trusted-ca-file", "/home/runner/work/etcd/etcd/tests/fixtures/ca.crt", "--cipher-suites", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305", "--initial-cluster", "TestV3CurlCipherSuitesMismatch-test-0=http://localhost:20001", "--initial-cluster-state", "new"], "working-dir": "/tmp/TestV3CurlCipherSuitesMismatch1594496831/001", "name": "TestV3CurlCipherSuitesMismatch-test-0", "environment-variables": ["ETCD_VERIFY=all", "EXPECT_DEBUG=true", "PATH=/opt/hostedtoolcache/go/1.19.7/x64/bin:/home/runner/go/bin:/opt/hostedtoolcache/go/1.19.7/x64/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin", "ETCD_UNSUPPORTED_ARCH=386"]}
2023-04-04T05:04:28.2113694Z logger.go:130: 2023-04-04T05:01:50.635Z INFO started server. {"name": "TestV3CurlCipherSuitesMismatch-test-0", "pid": 23610}
2023-04-04T05:04:28.2113895Z v3_cipher_suite_test.go:65:
2023-04-04T05:04:28.2114378Z Error Trace: /home/runner/work/etcd/etcd/tests/e2e/v3_cipher_suite_test.go:65
2023-04-04T05:04:28.2115147Z /home/runner/work/etcd/etcd/tests/e2e/ctl_v3_test.go:261
2023-04-04T05:04:28.2115901Z /opt/hostedtoolcache/go/1.19.7/x64/src/runtime/asm_386.s:1326
2023-04-04T05:04:28.2120103Z Error: Error "[curl --cacert /home/runner/work/etcd/etcd/tests/fixtures/ca.crt --cert /home/runner/work/etcd/etcd/tests/fixtures/server.crt --key /home/runner/work/etcd/etcd/tests/fixtures/server.key.insecure -L https://localhost:20000/metrics --ciphers ECDHE-RSA-DES-CBC3-SHA] match not found. Set EXPECT_DEBUG for more info Errs: [unexpected exit code [59] after running [/usr/bin/curl --cacert /home/runner/work/etcd/etcd/tests/fixtures/ca.crt --cert /home/runner/work/etcd/etcd/tests/fixtures/server.crt --key /home/runner/work/etcd/etcd/tests/fixtures/server.key.insecure -L https://localhost:20000/metrics --ciphers ECDHE-RSA-DES-CBC3-SHA]], last lines:\n (expected "failed setting cipher list", got []). Try EXPECT_DEBUG=TRUE" does not contain "curl: (59) failed setting cipher list"
2023-04-04T05:04:28.2120431Z Test: TestV3CurlCipherSuitesMismatch
2023-04-04T05:04:28.2120679Z ctl_v3_test.go:273: closing test cluster...
2023-04-04T05:04:28.2121302Z logger.go:130: 2023-04-04T05:01:50.652Z INFO stopping server... {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2121897Z logger.go:130: 2023-04-04T05:01:50.658Z INFO stopped server. {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2122305Z logger.go:130: 2023-04-04T05:01:50.658Z INFO closing test cluster...
2023-04-04T05:04:28.2122903Z logger.go:130: 2023-04-04T05:01:50.658Z INFO stopping server... {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2123492Z logger.go:130: 2023-04-04T05:01:50.658Z INFO closing server... {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2124074Z logger.go:130: 2023-04-04T05:01:50.658Z INFO stopping server... {"name": "TestV3CurlCipherSuitesMismatch-test-0"}
2023-04-04T05:04:28.2124957Z logger.go:130: 2023-04-04T05:01:50.658Z INFO removing directory {"data-dir": "/tmp/TestV3CurlCipherSuitesMismatch1594496831/002"}
2023-04-04T05:04:28.2125426Z logger.go:130: 2023-04-04T05:01:50.658Z INFO closed test cluster.
2023-04-04T05:04:28.2125663Z ctl_v3_test.go:277: closed test cluster...

ahrtr
ahrtr approved these changes Apr 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @lavacat

jmhbnz
jmhbnz approved these changes Apr 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lavacat , looks good.

@serathius serathius merged commit 5e0119e into etcd-io:main Apr 4, 2023
@jmhbnz jmhbnz mentioned this pull request Aug 19, 2023
Merged
@riendeau riendeau mentioned this pull request Aug 25, 2023
Closed
@serathius serathius mentioned this pull request Oct 17, 2023
Merged
@badouralix badouralix mentioned this pull request May 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestWatchDelay* tests are flaky

4 participants

@lavacat @serathius @ahrtr @jmhbnz