raft: update prevHardSt on Ready accept, not advance#14539
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Sep 30, 2022
Merged
raft: update prevHardSt on Ready accept, not advance#14539ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr merged 1 commit intoetcd-io:mainfrom
Conversation
This commit updates the `RawNode`'s `prevHardSt` to the new HardState in `acceptReady` instead of on `Advance`. This aligns the handling of `prevHardSt` with that of `prevSoftSt` (and other fields like `msgs`) and simplifies the logic in `Advance`. Signed-off-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
e4a0485 to
9a03632
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the
RawNode'sprevHardStto the new HardState inacceptReadyinstead of onAdvance. This aligns the handling ofprevHardStwith that ofprevSoftSt(and other fields likemsgs) and simplifies the logic inAdvance.cc. @tbg