Skip to content

[test] Fix test code compiling error due to not enough arguments #14401

Merged
serathius merged 1 commit intoetcd-io:mainfrom
ahrtr:ctx_error_20220830
Aug 30, 2022
Merged

[test] Fix test code compiling error due to not enough arguments #14401
serathius merged 1 commit intoetcd-io:mainfrom
ahrtr:ctx_error_20220830

Conversation

@ahrtr
Copy link
Copy Markdown
Member

@ahrtr ahrtr commented Aug 30, 2022

Pipeline error caused by 70de5c8

stderr: go: downloading golang.org/x/sync v0.0.0-20220601150217-0de741cfad7f
stderr: # go.etcd.io/etcd/tests/v3/e2e
Error: stderr: vet: e2e/ctl_v3_auth_test.go:1404:26: not enough arguments in call to node0.Restart
FAIL: (code:2):
  % (cd tests && 'go' 'vet' './...')

FAIL: 'run go vet ./...' checking failed (!=0 return code)
FAIL: 'govet' failed at Tue Aug 30 03:07:13 UTC 2022

Refer to https://github.com/etcd-io/etcd/runs/8083906786?check_suite_focus=true

Signed-off-by: Benjamin Wang wachao@vmware.com

cc @serathius @spzala @ptabor

I will update the CI to add build for the test code in a separate PR.

@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Aug 30, 2022

Found the issue when working on #14400

@ahrtr
Copy link
Copy Markdown
Member Author

ahrtr commented Aug 30, 2022

One more error,

DONE 1 tests in 0.001s
Saved JUnit XML test report to /home/runner/work/etcd/etcd/linux-386-unit-1-cpu/junit_MTY2MTgzNjI4Ngo.xml
% (cd tests && 'env' 'ETCD_VERIFY=all' 'go' 'test' '-v' '-json' '-short' '-timeout=3m' '--race=false' '--cpu=1' './...' '-p=4')
stderr: go: downloading golang.org/x/sync v0.0.0-20220601150217-0de741cfad7f
stderr: # go.etcd.io/etcd/tests/v3/e2e [go.etcd.io/etcd/tests/v3/e2e.test]
Error: stderr: e2e/no_quorum_ready_test.go:34:21: not enough arguments in call to epc.Start
stderr: have ()
stderr: want (context.Context)

Refer to https://github.com/etcd-io/etcd/runs/8084995160?check_suite_focus=true

@ahrtr
fix test code compiling error due to not enough arguments in call to …
e1c5d2a 
…node0.Restart

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr force-pushed the ctx_error_20220830 branch from 3fd1b42 to e1c5d2a Compare August 30, 2022 05:15
@ahrtr ahrtr mentioned this pull request Aug 30, 2022
Merged
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #14401 (e1c5d2a) into main (77773c7) will increase coverage by 4.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14401      +/-   ##
==========================================
+ Coverage   70.87%   75.23%   +4.35%     
==========================================
  Files         455      457       +2     
  Lines       37162    37183      +21     
==========================================
+ Hits        26339    27973    +1634     
+ Misses       9321     7440    -1881     
- Partials     1502     1770     +268
Flag Coverage Δ
all 75.23% <ø> (+4.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-11.63%) ⬇️
client/v3/leasing/util.go 88.33% <0.00%> (-10.00%) ⬇️
client/pkg/v3/fileutil/purge.go 66.03% <0.00%> (-7.55%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 72.39% <0.00%> (-5.21%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
server/etcdserver/txn/util.go 75.47% <0.00%> (-3.78%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0.00%> (-1.74%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-1.67%) ⬇️
... and 86 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr ahrtr mentioned this pull request Aug 30, 2022
Closed
@serathius serathius merged commit cdd2b73 into etcd-io:main Aug 30, 2022
spzala
spzala reviewed Aug 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @ahrtr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spzala spzala spzala left review comments

@serathius serathius serathius approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahrtr @codecov-commenter @serathius @spzala