Reduce redundant code and memory allocation.#14374
Merged
ptabor merged 1 commit intoetcd-io:mainfrom Aug 29, 2022
Merged
Conversation
Author
|
@ahrtr Could you review the code? |
Member
|
Please signoff the commit using |
Signed-off-by: comolli <liangweicheng2@gmail.com>
Author
|
@ahrtr That my fault,I will check the https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow. first next time ,thank you for your time. |
Member
|
Usually it isn't recommended to update the stable But the change in PR looks good and safe to me. cc @spzala @serathius @ptabor |
ahrtr
approved these changes
Aug 24, 2022
ptabor
approved these changes
Aug 29, 2022
Contributor
|
LGTM. Thank you. I don't see any risk. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.