tests: fix the logic of testNonleaderElectionTimeoutRandomized in raft_paper_test.go#14273
Merged
serathius merged 1 commit intoetcd-io:mainfrom Jul 26, 2022
Merged
tests: fix the logic of testNonleaderElectionTimeoutRandomized in raft_paper_test.go#14273serathius merged 1 commit intoetcd-io:mainfrom
serathius merged 1 commit intoetcd-io:mainfrom
Conversation
…t_paper_test.go In the test `testNonleaderElectionTimeoutRandomized`, the possible values of election timeout randomized out should be 10-19(inclusive), but the current test only tests the possible values as 11-19(inclusive), which is incorrect here. We need to expand the scope of the tests to ensure robustness, and also to make the logic clearer. Signed-off-by: Zike Yang <zike@apache.org>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test
testNonleaderElectionTimeoutRandomized, the possible values of election timeout randomized out should be 10-19(inclusive), but the current test only tests the possible values as 11-19(inclusive), which may be incorrect here. We need to expand the scope of the tests to ensure robustness and make the logic clearer.Signed-off-by: Zike Yang zike@apache.org