Skip to content

etcdctl: Remove V2 API commands#13643

Merged
serathius merged 1 commit intoetcd-io:mainfrom
serathius:remove-etcdctl-v2
Apr 24, 2022
Merged

etcdctl: Remove V2 API commands#13643
serathius merged 1 commit intoetcd-io:mainfrom
serathius:remove-etcdctl-v2

Conversation

@serathius
Copy link
Copy Markdown
Member

@serathius serathius commented Jan 25, 2022

@serathius serathius marked this pull request as draft January 26, 2022 11:15
@serathius serathius force-pushed the remove-etcdctl-v2 branch 3 times, most recently from 2c8d0f7 to 52b1e15 Compare January 26, 2022 14:20
@serathius serathius marked this pull request as ready for review January 26, 2022 14:39
@serathius
Copy link
Copy Markdown
Member Author

serathius commented Jan 26, 2022

cc @ptabor @spzala @ahrtr

@serathius serathius mentioned this pull request Jan 28, 2022
Closed
@serathius serathius requested a review from ptabor February 2, 2022 12:54
ahrtr
ahrtr approved these changes Feb 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius
Copy link
Copy Markdown
Member Author

serathius commented Feb 22, 2022

cc @ptabor

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #13643 (44161ed) into main (bf0b1a7) will increase coverage by 2.48%.
The diff coverage is 78.69%.

❗ Current head 44161ed differs from pull request most recent head 6da1c3a. Consider uploading reports for the commit 6da1c3a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13643      +/-   ##
==========================================
+ Coverage   72.57%   75.05%   +2.48%     
==========================================
  Files         465      444      -21     
  Lines       37856    36962     -894     
==========================================
+ Hits        27475    27743     +268     
+ Misses       8596     7405    -1191     
- Partials     1785     1814      +29
Flag Coverage Δ
all 75.05% <78.69%> (+2.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 79.51% <ø> (ø)
server/etcdmain/etcd.go 45.16% <0.00%> (-0.60%) ⬇️
server/etcdserver/bootstrap.go 68.79% <25.00%> (+0.67%) ⬆️
etcdctl/main.go 40.00% <33.33%> (+15.00%) ⬆️
server/embed/config.go 74.00% <68.42%> (+0.82%) ⬆️
server/etcdserver/api/v3discovery/discovery.go 80.00% <80.00%> (ø)
etcdctl/ctlv3/command/printer_json.go 77.35% <100.00%> (ø)
server/embed/etcd.go 74.80% <100.00%> (+0.60%) ⬆️
server/etcdmain/config.go 84.94% <100.00%> (+0.67%) ⬆️
server/auth/simple_token.go 80.00% <0.00%> (-8.47%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0b1a7...6da1c3a. Read the comment docs.

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 7, 2022

One more comment, we still support v2 discovery in 3.6. Should we keep the V2 commands, and delete them together the clientv2 & v2 discovery in future?

This was referenced Apr 22, 2022
Merged
Merged
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Apr 22, 2022

FYI discussion_r855723472

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Apr 23, 2022

@serathius Please rebase this PR. I think it's OK to merge this PR for 3.6. The sever side V2 code has already been removed, so there is no reason to keep the V2 commands. If users need the v2 command, then they can get it from the previous releases, such as 3.5 or 3.4.

@serathius serathius merged commit b00bb53 into etcd-io:main Apr 24, 2022
@serathius serathius mentioned this pull request May 2, 2023
Open
33 tasks
@serathius serathius deleted the remove-etcdctl-v2 branch June 15, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahrtr ahrtr ahrtr approved these changes

@ptabor ptabor Awaiting requested review from ptabor

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serathius @codecov-commenter @ahrtr