Conversation
|
cc @serathius @hexfusion @ptabor please take a look thanks! |
serathius
left a comment
There was a problem hiding this comment.
Looks great, however we need to do something with SemaphoreCI. We need to either:
- Disable it
- Release new gcr.io/etcd-development/etcd-test:go1.17.2 image
I think long term we should disable SemaphoreCI. Recent releases v3.4, v3.5 were migrated to GitHubCi so there is no sense to try to maintain etcd-test images.
|
I am happy with either way, but agreed disabling SemaphoreCI makes the most sense. @ptabor @hexfusion any preferences? |
|
It makes sense as @serathius described to eliminate test image dependency. For the sake of merging this PR, I pushed up the new gcr.io/etcd-development/etcd-test:go1.17.2 image. Please retest. |
|
That passed, but seems like I hit a grpcProxy flake, will retest again. |
|
Green now 🟢 @serathius @hexfusion please take a look again, thanks! |
Closes #13314