raft: avoid jump tag to make code more understandable#13438
Merged
ptabor merged 1 commit intoetcd-io:mainfrom Jan 15, 2022
Merged
raft: avoid jump tag to make code more understandable#13438ptabor merged 1 commit intoetcd-io:mainfrom
ptabor merged 1 commit intoetcd-io:mainfrom
Conversation
serathius
approved these changes
Oct 26, 2021
Member
serathius
left a comment
There was a problem hiding this comment.
Overall I think that we should consider splitting this into separate function, however this is still an acceptable improvement.
ptabor
approved these changes
Oct 29, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.