Documentation Content: TOC — Sections Order#12509
Merged
spzala merged 1 commit intoetcd-io:masterfrom Dec 19, 2020
Merged
Conversation
This was referenced Dec 3, 2020
cfc4n
approved these changes
Dec 4, 2020
Contributor
Author
Contributor
Author
|
Note, CI failure is not related to doc change. |
This was referenced Dec 4, 2020
spzala
reviewed
Dec 5, 2020
Member
spzala
left a comment
There was a problem hiding this comment.
Hi @nate-double-u lgtm but nits,
- I guess all the files here still needs
descriptions? - Can we keep please order as below:
- Learning
- Developer guide
- Operations guide
- Benchmarks
- Upgrading
- Platforms
- Triage
You can hold on to making changes for a day or two if anyone else has comments but otherwise I would make the order as above. (also, I think Triage doesn't belong here but let's not complicate things here, we can do that in separately in future) Thanks!
Contributor
Author
|
Thanks for the feedback! I'm doing descriptions separately in other PRs as I think they'll probably need a closer look. |
Member
OK, that's fine. Thanks! |
Updating for new TOC as per issue etcd-io/website#81 Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
c5ec811 to
bedad02
Compare
Contributor
Author
Updated. |
Contributor
Author
|
With these changes I think this PR is ready for merge now. |
This was referenced Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the primary sections order by adding
weights to main section.mdfiles.Related to issue etcd-io/website#81
* Benchmarks
* Developer guide
* Learning
* Operations guide
* Platforms
* Triage
* Upgrading
* Learning
* Developer guide
* Operations guide
* Benchmarks
* Upgrading
* Platforms
* Triage
This is a first pass on the order. Feedback is welcome!