tools: Update tools & go.mod for protos (gogo/protobuf 1.3.1, grpc 1.29.1, grpc-gateway 1.14.6)#12397
Merged
gyuho merged 3 commits intoetcd-io:masterfrom Oct 14, 2020
Merged
Conversation
… grpc-gateway 1.14.6) This brings consistency between proto-generation code and actual versions of libraries being used in runtime: github.com/gogo/protobuf v1.2.1,v1.0.0 -> v1.3.1 github.com/golang/protobuf v1.3.2 -> v1.3.5 github.com/grpc-ecosystem/grpc-gateway v1.9.5,v1.4.1,v1.15.2 -> v1.14.6 google.golang.org/grpc v1.26.0 -> v1.29.1 Moved as far as possible, without bumping on grpc 1.30.0 "naming" decomissioning. Please also notice that gogo/protobuf is likely to reach EOL: gogo/protobuf#691
Contributor
|
lgtm |
b7c5aef to
371ddf0
Compare
gyuho
approved these changes
Oct 14, 2020
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools: Update of go.mod for protos (gogo/protobuf 1.3.1, grpc 1.29.1, grpc-gateway 1.14.6)
This brings consistency between proto-generation code and actual versions of libraries being used in runtime:
Moved as far as possible, without bumping on grpc 1.30.0 "naming" decomissioning.
Please also notice that gogo/protobuf is likely to reach EOL: gogo/protobuf#691,
so we should consider migration to the other generator.