Skip to content

[release-1.4] Revert "Merge pull request #969 from nspcc-dev/drop-unused-txs"#974

Merged
ahrtr merged 1 commit intoetcd-io:release-1.4from
Elbehery:20250609-revert-drop-unused-txs-list
Jun 10, 2025
Merged

[release-1.4] Revert "Merge pull request #969 from nspcc-dev/drop-unused-txs"#974
ahrtr merged 1 commit intoetcd-io:release-1.4from
Elbehery:20250609-revert-drop-unused-txs-list

Conversation

@Elbehery
Copy link
Member

@Elbehery Elbehery commented Jun 9, 2025

This reverts #969

addresses comment #969 (comment)

cc @ahrtr @ivanvc

This reverts commit f33bb13, reversing
changes made to cc41cbb.

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery Elbehery force-pushed the 20250609-revert-drop-unused-txs-list branch from c31eed3 to 2b74b9b Compare June 9, 2025 19:01
@ahrtr ahrtr changed the title Revert "Merge pull request #969 from nspcc-dev/drop-unused-txs" [release-1.4] Revert "Merge pull request #969 from nspcc-dev/drop-unused-txs" Jun 9, 2025
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Elbehery for the help.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Elbehery.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, Elbehery, fuweid, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 5fa0ab8 into etcd-io:release-1.4 Jun 10, 2025
11 checks passed
@Elbehery Elbehery deleted the 20250609-revert-drop-unused-txs-list branch June 11, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants