move array related freelist functions into own file#777
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Jun 26, 2024
Merged
Conversation
ahrtr
reviewed
Jun 26, 2024
| // write writes the page ids onto a freelist page. All free and pending ids are | ||
| // saved to disk since in the event of a program crash, all pending ids will | ||
| // become free. | ||
| func (f *freelist) write(p *common.Page) error { |
Member
There was a problem hiding this comment.
Please keep the write method in freelist.go because it has nothing to do with array or hashmap freelistType.
Contributor
Author
There was a problem hiding this comment.
copied too eagerly, moved it back where it was
92ea985 to
39a1105
Compare
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
39a1105 to
a4a52a2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.