Use findlib configs instead of env variables#732
Use findlib configs instead of env variables#732rauanmayemir wants to merge 7 commits intomasterfrom
Conversation
|
Would be interesting to try this approach — for each package we can produce a prefix (a path with As a side effect — we'll get env size reduction because we won't need to accumulate all packages's |
|
Let me try that after I make findlib configs work in all envs. |
8581204 to
5a55f88
Compare
5a55f88 to
efba7f8
Compare
|
This is ready for review. I'd like to wrap this up as quickly as possible and move to other related issues. |
efba7f8 to
fcbd3fd
Compare
andreypopp
left a comment
There was a problem hiding this comment.
Looks great! Discussed offline with @rauanmayemir: In the current implementation it is required for package build to be executed before esy CMD starts seeing findlib.conf — otherwise it's working great!
75b7992 to
1b40a68
Compare
This will check the existance of findlib config in command environment when the project hasn't yet been build. The plan is to add a 'hack' to create `findlib.conf` before running any invocations even though usually we only create it on `esy-b-p` phase
This mixed diff adds a new `prefixPath` notion and a new `p` directory in a package store. It also refactors build plan to accept streamlined list of files and emit them into the package prefix.
1b40a68 to
b810c4a
Compare
|
After refactoring, we now create a package-level prefix and store build config in it. We also make sure that the prefix exists even for Current use of prefix is limited to keeping |
|
Going to close this for now, we are going to try creating a package-specific prefix in the next version of the builder though. This concept seems sound. |
This PR adds an ability to generate findlib configs as part of the build plan and then put those files in place during build phase.
I suspect that at this point this is no longer an optimal solution as we have sandboxes, and it might be better to generate findlib configs during sandbox configuration phase.
@andreypopp Thoughts?