fix: mysql.ready called before functions.lua is loaded#1780
Merged
Conversation
|
|
Zykem
approved these changes
May 8, 2026
Zykem
left a comment
Member
There was a problem hiding this comment.
Thanks @FabianTerhorst, merging.
Note: this isn't fixing a current bug. It's prep for an upcoming FiveM scheduler change where CreateThreadNow runs on the current stack instead of deferring. Under that, MySQL.ready could fire before functions.lua loads and ESX.RefreshJobs would be nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code inside
common.luais awaiting mysql to be ready. When its ready it is executing RefreshJobs. This function is loaded from inside functions.lua which is below the common.lua inside the manifest. This change fixes the load order and makes sure RefreshJobs is always loaded before common.lua is executed.PR Checklist