fix(es_extended/shared/functions): fix ESX.GetConfig bug#1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in
ESX.GetConfigwhere falsy config values (e.g.,false,nil) would incorrectly cause the function to return the entireConfigtable instead of the actual value. This ensures accurate value retrieval even for falsy config values.Motivation
The previous inline logic using
and/orwould fall back to returning the full config ifConfig[key]was falsy. This behavior was incorrect and caused issues when a config value was intentionallyfalse. This change fixes that logic.Implementation Details
Replaced the ternary-style one-liner with a simple
ifstatement to explicitly check if thekeyparameter is notnil. This avoids misinterpreting falsy values and ensures proper return values.Updated function:
Usage Example
PR Checklist