Skip to content

refactor: esx inv into menu_default & separate resource#1697

Merged
Kenshiin13 merged 15 commits into
devfrom
inv
Aug 13, 2025
Merged

refactor: esx inv into menu_default & separate resource#1697
Kenshiin13 merged 15 commits into
devfrom
inv

Conversation

@Kenshiin13

@Kenshiin13 Kenshiin13 commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Description

This PR refactors the ESX inventory system to:

  • Replace context menus with default menus for better UX.
  • Restructure the inventory logic into modular helper functions for improved maintainability and readability.
  • Separate the inventory into its own dedicated resource, making it easier to update, manage, and customize.

Motivation

The previous implementation relied heavily on context menus with inline logic, making it harder to maintain and extend.
By moving to esx_menu_default and extracting menu building into helper functions, we:

  • Improve readability by reducing inline complexity.
  • Allow future enhancements (sorting, filtering, item categorization) without touching core ESX files.
  • Make it easier for server owners to customize their inventory system.

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

Comment thread [core]/esx_inventory/client/main.lua Outdated
Comment thread [core]/esx_inventory/client/main.lua Outdated
Comment thread [core]/esx_inventory/client/main.lua Outdated
Comment thread [core]/esx_inventory/client/main.lua Outdated
Comment thread [core]/esx_inventory/fxmanifest.lua
@Kenshiin13 Kenshiin13 requested a review from Zykem August 12, 2025 19:35

@Zykem Zykem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@Kenshiin13 Kenshiin13 merged commit 92fc57e into dev Aug 13, 2025
2 of 3 checks passed
@Kenshiin13 Kenshiin13 deleted the inv branch August 13, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants