Fix onPlayerDropped to pass in cb#1695
Merged
Merged
Conversation
When third-party scripts use
```lua
debugPrint('[LOGOUT] Awaiting Player to be unloaded [/]')
TriggerEvent('esx:playerLogout', source, function()
cb()
debugPrint('[LOGOUT] Player unloaded.')
end)
```
the issue of not passing in functions
Zykem
approved these changes
Aug 7, 2025
Zykem
requested changes
Aug 7, 2025
Zykem
left a comment
Member
There was a problem hiding this comment.
Can you please change the target branch to dev instead of main?
Contributor
Author
|
Sorry, I thought this was a hotfix, so I just requested a merge. |
Javier143322
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed missing
cbparameter inonPlayerDroppedfunctionMotivation
Resolving issues with the required
cbcallback function when certain third-party scripts use theesx:playerLogoutevent.Implementation Details
Add the
cbparameter to theonPlayerDroppedfunction again.Usage Example
PR Checklist