Skip to content

Fix onPlayerDropped to pass in cb#1695

Merged
Zykem merged 1 commit into
esx-framework:devfrom
DyroS3:main
Aug 8, 2025
Merged

Fix onPlayerDropped to pass in cb#1695
Zykem merged 1 commit into
esx-framework:devfrom
DyroS3:main

Conversation

@DyroS3

@DyroS3 DyroS3 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Description

Fixed missing cb parameter in onPlayerDropped function


Motivation

Resolving issues with the required cb callback function when certain third-party scripts use the esx:playerLogout event.


Implementation Details

Add the cb parameter to the onPlayerDropped function again.


Usage Example

debugPrint('[LOGOUT] Awaiting Player to be unloaded [/]')
TriggerEvent('esx:playerLogout', source, function()
	cb()
	debugPrint('[LOGOUT] Player unloaded.')
end)

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

When third-party scripts use
```lua
debugPrint('[LOGOUT] Awaiting Player to be unloaded [/]')
TriggerEvent('esx:playerLogout', source, function()
	cb()
	debugPrint('[LOGOUT] Player unloaded.')
end)
```
the issue of not passing in functions

@Zykem Zykem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the target branch to dev instead of main?

@DyroS3

DyroS3 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, I thought this was a hotfix, so I just requested a merge.

@DyroS3 DyroS3 changed the base branch from main to dev August 7, 2025 13:19
@DyroS3 DyroS3 requested a review from Zykem August 7, 2025 13:22

@Zykem Zykem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Zykem Zykem merged commit d2fbf4a into esx-framework:dev Aug 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants