Fix Discord Rich Presence integration#1692
Merged
Merged
Conversation
Tiziukas
suggested changes
Aug 5, 2025
Tiziukas
left a comment
There was a problem hiding this comment.
Everything looks fine, guidelines are followed and the code works.
Please review the comment, once this is fixed, we can merge.
Sorry for being picky :)
Zykem
requested changes
Aug 7, 2025
Member
There was a problem hiding this comment.
Hi, thanks for your PR.
I don't think the PresencePlaceholders should exist, it seems like it's just a wrapper for the actual ReplacePlaceholders, it's not doing anything more than just calling this function and returning it's return value.
Please use ReplacePlaceholders instead.
If your concern is code readability, you can localize it and name it something readable before using it for SetRichPresence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the discord activity that was not working. The problem before was that some variable in for example {server_endpoint}, were never replaced so it created invalid URL and in assetText {server_name} was not replaced too.
Motivation
To fix the discord Presence
Implementation Details
New function Adjustments:ReplacePlaceholders(text) that replace correctly all the placeholder in a text
Adjustments:PresencePlaceholders() use the new ReplacePlaceholders function to create the presence text.
SetDiscordRichPresenceAssetText and buttonUrl use ReplacePlaceholders to replace the placeholders by the actuals values
Usage Example
PR Checklist