Skip to content

feat(esx_core) Added pcall for checking player identifier as new ESX.GetIdentifier retruns error when identifier isn't found.#1691

Merged
Kenshiin13 merged 1 commit into
esx-framework:devfrom
Kr3mu:license_deffer
Aug 1, 2025
Merged

feat(esx_core) Added pcall for checking player identifier as new ESX.GetIdentifier retruns error when identifier isn't found.#1691
Kenshiin13 merged 1 commit into
esx-framework:devfrom
Kr3mu:license_deffer

Conversation

@Kr3mu

@Kr3mu Kr3mu commented Aug 1, 2025

Copy link
Copy Markdown
Member

Description

  • Adds a pcall for esx_identity, esx_multicharacter, es_exteneded, to prevent player from joining and to show them deffer error.

Motivation

  • It solves a loop of resource_name deferring. connection.. As it didn't notify a player when server owner set their license type wrong.

Implementation Details

  • Adds a pcall to every playerConnecting

Usage Example

  • No usage

PR Checklist

  • [ +] My commit messages and PR title follow the Conventional Commits standard.
  • [ +] My changes have been tested locally and function as expected.
  • [ +] My PR does not introduce any breaking changes.
  • [ +] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.
image image

@Kr3mu Kr3mu requested a review from Kenshiin13 August 1, 2025 10:04

@Kenshiin13 Kenshiin13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm

@Kenshiin13 Kenshiin13 merged commit 2d2f068 into esx-framework:dev Aug 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants