feat(esx_notify): add toggle for notification sound playback#1687
Merged
Conversation
This PR adds support for enabling or disabling the notification sound in `esx_notify`. A new variable `NotificationSoundEnabled` (default: true) controls whether a sound should be played when a notification is shown. ```lua ---@type boolean Whether the notification sound should be played local NotificationSoundEnabled = true ``` - [x] My commit messages and PR title follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. - [ ] My changes have been tested locally and function as expected. - [x] My PR does not introduce any breaking changes. - [x] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.
Kenshiin13
suggested changes
Jul 28, 2025
Kenshiin13
suggested changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for enabling or disabling the notification sound in
esx_notify. A new variableNotificationSoundEnabled(default: true) controls whether a sound should be played when a notification is shown.