Update callback.lua#1668
Merged
Merged
Conversation
This PR modifies the Callbacks:Execute method to improve error handling when a callback fails.
Contributor
|
I don't see any issues with throwing an error. Setting currentId to nil on failure is a good catch though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the Callbacks:Execute method to improve error handling when a callback fails.
Motivation
Using error() after pcall() defeats the purpose of safe error handling and can cause disruptive stack traces or unwanted crashes during runtime (e.g., when spawning an invalid vehicle model). This change allows errors to be logged without halting execution.
Implementation Details