Skip to content

fix(esx_multicharacter): cleanup stale player obj#1662

Merged
Kenshiin13 merged 3 commits into
esx-framework:devfrom
Kenshiin13:stale-player
Jul 6, 2025
Merged

fix(esx_multicharacter): cleanup stale player obj#1662
Kenshiin13 merged 3 commits into
esx-framework:devfrom
Kenshiin13:stale-player

Conversation

@Kenshiin13

@Kenshiin13 Kenshiin13 commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

Description

Clean up stale player entries even for players who crashed during multichar select.


Motivation

We already introduced a cleanup mechanism for players who already chose a character, but no such mechancism existed for players who crashed during char select.


Implementation Details

Save source to ESX.Players table so we can later test if that source is still an active player. Otherwise we can initiate cleanup of the stale player obj.


PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@github-project-automation github-project-automation Bot moved this to 🆕 To be Discussed in ESX Roadmap Jul 6, 2025

@Zykem Zykem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@github-project-automation github-project-automation Bot moved this from 🆕 To be Discussed to Ready for Next Update in ESX Roadmap Jul 6, 2025
@Kenshiin13 Kenshiin13 merged commit 68a8a59 into esx-framework:dev Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Next Update

Development

Successfully merging this pull request may close these issues.

3 participants