fix(config): update minimum age year from 2005 to 2007 for accuracy#1626
fix(config): update minimum age year from 2005 to 2007 for accuracy#1626PhilCode-creator wants to merge 1 commit into
Conversation
|
Hello, can you change the comment that tells how old you’ll be today, please? |
what exactly do you mean with that? I mean thats the old one or do you mean with the pr |
Line 16 of the file in the comment if you can update the age do it can be accurate please. |
|
You could instead do the calculation automatically by simply specifying the min. age required..? Do you want to keep coming back every year to PR such changes? |
There was a problem hiding this comment.
Hey, thanks for the PR! Can you update the script to automatically set the minimum age to 18, instead of just changing the config value? That way, it will be handled dynamically. We dont want to continue working with the same bad code from the previous team members, so we prefer to upgrade ESX properly.
Eventually, you could create a new config property like:
Config.MinimumAge = 18
Then, when registering the identity, you can check the users age to make sure it matches the minimum age set in the config. But we wont approve changes that continue to use this “bad” code.
|
Hi, we implemented a different solution for this problem. Thank you for the effort you put in this PR. |
Description
Just a update to match the right year because its 2025 and you can be 18 years old if you are born in 2007
Motivation
I just opend the config and it bothered me
Implementation Details
Just a Config value update
Usage Example
None
PR Checklist