Skip to content

fix(es_extended/imports): remove lua 5.4 dependency for importing resources#1575

Merged
Kenshiin13 merged 2 commits into
esx-framework:devfrom
Kenshiin13:fix-import
Jan 2, 2025
Merged

fix(es_extended/imports): remove lua 5.4 dependency for importing resources#1575
Kenshiin13 merged 2 commits into
esx-framework:devfrom
Kenshiin13:fix-import

Conversation

@Kenshiin13

@Kenshiin13 Kenshiin13 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Removed usage of optional chaining (a 5.4 feature) in the imports.lua.
  • Fixed return value of ESX.GetItems. Returned nil because of this revert

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@Kenshiin13 Kenshiin13 self-assigned this Jan 2, 2025
@Kenshiin13 Kenshiin13 merged commit 721f486 into esx-framework:dev Jan 2, 2025
@Kenshiin13 Kenshiin13 deleted the fix-import branch January 2, 2025 18:45
@Kenshiin13 Kenshiin13 mentioned this pull request Jan 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mycroft-Studios Mycroft-Studios Mycroft-Studios approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Kenshiin13 Kenshiin13

Labels

None yet

Projects

ESX Roadmap
Status: Ready for Next Update

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kenshiin13 @Mycroft-Studios