add ability for RNG to restart from a prior state#283
Merged
jkrajniak merged 2 commits intoespressopp:masterfrom May 1, 2019
Merged
add ability for RNG to restart from a prior state#283jkrajniak merged 2 commits intoespressopp:masterfrom
jkrajniak merged 2 commits intoespressopp:masterfrom
Conversation
jkrajniak
reviewed
Apr 19, 2019
| @@ -3,27 +3,32 @@ | |||
| Max Planck Institute for Polymer Research | |||
| return boostRNG; | ||
| } | ||
|
|
||
| void RNG::save_state(int step){ |
Member
There was a problem hiding this comment.
I preferr to use camelCase in C++ code
| void RNG::save_state(int step){ | ||
| std::ostringstream oss; | ||
| oss << *boostRNG; | ||
| if ( mpiWorld->rank()!=0 ) { |
Member
There was a problem hiding this comment.
Note, the convention is usually to have if (rank==0) { ....} else {....}
Contributor
Author
|
Hello Jakub, I have made requested changes to the code. Best, |
jkrajniak
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added two functions to the RNG class so that it is possible to save the state RNG to a file and restart from the same state from the file.