Add PIDs for the ESP32-S3-Super-Mini#181
Closed
justM4D wants to merge 1 commit into
Closed
Conversation
Member
|
Oh my, looks like they inadvertently added a non-applicable pull request template here. Let's see if I can fix it. |
Member
|
Generally, this looks good, although I would indeed use 'generic' rather than 'Aliexpress' as Aliexpress is not the manufacturer. Unfortunately, the bad issue template messed up this PR (I can't get it out of 'draft' state anymore) so I need to close it. Would you mind making it again? It should put something more applicable in the PR description if you do so, but you can also just copy-paste the text you wrote above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For a while there have been "ESP32-S3 Super Mini" Boards (with a "ESP32-S3FH4R2" chip) floating around on Aliexpress and other chinese marketplaces.
I couldn't find out who the original designer is, since all shops just use the same pictures and diagrams with different watermarks.
Apparently there are revisions with the open source logo on them, but even so I couldn't find any more infos on the board than on the shops and this chinese site.
If it's a clone, I couldn't find the original.
(They are often listed together with the C3-Super-Mini variants, which look like Waveshare clones, but they don't have a variant of the S3 Super Mini I could find anywhere)
All that is to say, I'd like to add this board to the usual places, so it can be used with Arduino and Micro-/CircuitPython without any guesswork for the users.
Since I couldn't make out a company, I put in "Aliexpress" as company name.
Maybe we could discuss a "N/A" or "Generic", "OEM", "Knockoff" or something instead :)