[mipi_dsi] Fix Waveshare P4 7B board config#14372
Merged
clydebarrow merged 1 commit intoesphome:devfrom Feb 28, 2026
Merged
Conversation
Contributor
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#14372
components: [mipi_dsi]
refresh: 1h(Added by the PR bot) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #14372 +/- ##
=======================================
Coverage 74.28% 74.28%
=======================================
Files 55 55
Lines 11597 11597
Branches 1583 1583
=======================================
Hits 8615 8615
Misses 2578 2578
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Waveshare MIPI DSI model definitions by adding the missing reset-pin default for the P4 Touch 7B board and simplifying the P4-86 panel init sequence to avoid redundant commands.
Changes:
- Add
reset_pin=33default forWAVESHARE-ESP32-P4-WIFI6-TOUCH-LCD-7B. - Remove redundant
0x11/0x29commands from theWAVESHARE-P4-86-PANELmodel init sequence.
bdraco
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The Waveshare P4 Touch 7B board was missing a reset pin config option.
Also remove redundant init sequence commands from the P4-86 config
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: