[max7219digit] Fix typo in action names#14162
Conversation
All actions were registered with `max7129digit` instead of `max7219digit` (transposed digits 1/2), making them impossible to use with the correct component name. fixes esphome#14154 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#14162
components: [max7219digit]
refresh: 1h(Added by the PR bot) |
|
👋 Hi there! This PR modifies 1 file(s) with codeowners. @rspaargaren - As codeowner(s) of the affected files, your review would be appreciated! 🙏 Note: Automatic review request may have failed, but you're still welcome to review. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a long-standing typo in the max7219digit component where all action names were registered with max7129digit (digits 1 and 2 transposed) instead of max7219digit, making the documented action names impossible to use. The fix addresses issue #14154 where users couldn't invoke actions like max7219digit.reverse_on because they were only registered under the misspelled name.
Changes:
- Corrected all 8 action registrations in
display.pyfrommax7129digit.*tomax7219digit.* - Updated corresponding function names to use correct component name prefix
- Updated test configuration to use corrected action names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
esphome/components/max7219digit/display.py |
Fixed typo in all action registrations and function names (max7129digit → max7219digit) |
tests/components/max7219digit/common.yaml |
Updated test to use corrected action names |
Memory Impact AnalysisComponents:
This analysis runs automatically when components change. Memory usage is measured from a representative test configuration. |
|
Thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #14162 +/- ##
==========================================
+ Coverage 74.08% 74.11% +0.02%
==========================================
Files 55 55
Lines 11590 11590
Branches 1578 1578
==========================================
+ Hits 8587 8590 +3
+ Misses 2600 2598 -2
+ Partials 403 402 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this implement/fix?
All max7219digit actions were registered with the name
max7129digit(transposed digits1and2) instead ofmax7219digit, making the actions impossible to use with the correct component name. For example,max7219digit.reverse_onwould fail with "Unable to find action", and only the mistypedmax7129digit.reverse_onwould work.This is a breaking change for anyone who discovered and used the typo'd action names, but since the documented names never worked, this is effectively a bugfix.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: