Skip to content

[max7219digit] Fix typo in action names#14162

Merged
swoboda1337 merged 1 commit intoesphome:devfrom
swoboda1337:fix-max7219digit-action-typo
Feb 20, 2026
Merged

[max7219digit] Fix typo in action names#14162
swoboda1337 merged 1 commit intoesphome:devfrom
swoboda1337:fix-max7219digit-action-typo

Conversation

@swoboda1337
Copy link
Member

What does this implement/fix?

All max7219digit actions were registered with the name max7129digit (transposed digits 1 and 2) instead of max7219digit, making the actions impossible to use with the correct component name. For example, max7219digit.reverse_on would fail with "Unable to find action", and only the mistyped max7129digit.reverse_on would work.

This is a breaking change for anyone who discovered and used the typo'd action names, but since the documented names never worked, this is effectively a bugfix.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Developer breaking change (an API change that could break external components)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • LN882x
  • nRF52840

Example entry for config.yaml:

display:
  - platform: max7219digit
    cs_pin: GPIO15
    num_chips: 4
    id: my_matrix
    lambda: |-
      it.print(0, 0, id(font1), "Hello");

binary_sensor:
  - platform: gpio
    pin: GPIO16
    on_press:
      then:
        - max7219digit.reverse_on:
    on_release:
      then:
        - max7219digit.reverse_off:

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

All actions were registered with `max7129digit` instead of `max7219digit`
(transposed digits 1/2), making them impossible to use with the correct
component name.

fixes esphome#14154

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 20, 2026 19:47
@github-actions
Copy link
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#14162
    components: [max7219digit]
    refresh: 1h

(Added by the PR bot)

@github-actions
Copy link
Contributor

👋 Hi there! This PR modifies 1 file(s) with codeowners.

@rspaargaren - As codeowner(s) of the affected files, your review would be appreciated! 🙏

Note: Automatic review request may have failed, but you're still welcome to review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a long-standing typo in the max7219digit component where all action names were registered with max7129digit (digits 1 and 2 transposed) instead of max7219digit, making the documented action names impossible to use. The fix addresses issue #14154 where users couldn't invoke actions like max7219digit.reverse_on because they were only registered under the misspelled name.

Changes:

  • Corrected all 8 action registrations in display.py from max7129digit.* to max7219digit.*
  • Updated corresponding function names to use correct component name prefix
  • Updated test configuration to use corrected action names

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
esphome/components/max7219digit/display.py Fixed typo in all action registrations and function names (max7129digit → max7219digit)
tests/components/max7219digit/common.yaml Updated test to use corrected action names

@swoboda1337 swoboda1337 modified the milestone: 2026.2.2 Feb 20, 2026
@github-actions
Copy link
Contributor

Memory Impact Analysis

Components: max7219digit
Platform: esp8266-ard

Metric Target Branch This PR Change
RAM 28,644 bytes 28,644 bytes ➡️ +0 bytes (0.00%)
Flash 295,251 bytes 295,251 bytes ➡️ +0 bytes (0.00%)

Note: This analysis measures static RAM and Flash usage only (compile-time allocation).
Dynamic memory (heap) cannot be measured automatically.
⚠️ You must test this PR on a real device to measure free heap and ensure no runtime memory issues.

This analysis runs automatically when components change. Memory usage is measured from a representative test configuration.

@swoboda1337 swoboda1337 merged commit db6aa58 into esphome:dev Feb 20, 2026
41 checks passed
@swoboda1337
Copy link
Member Author

Thanks

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.11%. Comparing base (edfc3e3) to head (204d380).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #14162      +/-   ##
==========================================
+ Coverage   74.08%   74.11%   +0.02%     
==========================================
  Files          55       55              
  Lines       11590    11590              
  Branches     1578     1578              
==========================================
+ Hits         8587     8590       +3     
+ Misses       2600     2598       -2     
+ Partials      403      402       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

max7219 inverting action doesn't work

5 participants