[mipi_dsi] Disallow swap_xy#14124
Conversation
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#14124
components: [mipi_dsi]
refresh: 1h(Added by the PR bot) |
There was a problem hiding this comment.
Pull request overview
This PR disallows the swap_xy transform for all MIPI DSI display models by setting swap_xy=cv.UNDEFINED and explicitly rejecting it in the transform schema. This prevents DSI displays from attempting to use hardware rotation modes that require axis swapping, which DSI hardware fundamentally doesn't support.
Changes:
- Modified
model_schemato disallow swap_xy for all DSI models - Simplified dimension validation logic by removing swap_xy-related conditionals
- Removed rotation-to-transform conversion code
- Cleaned up unused imports (CONF_ROTATION, CONF_WIDTH)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #14124 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 55 55
Lines 11590 11590
Branches 1578 1578
=======================================
Hits 8590 8590
Misses 2598 2598
Partials 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this implement/fix?
Custom model DSI display would try to use hardware rotation. This disallows swapping x/y for all DSI models since DSI fundamentally doesn't appear to support it (could be re-enabled in the future if a use-case is demonstrated.)
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: